RE: [PATCH v1 0/2] RDMA network namespace issue fixes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Qingmin Liu [mailto:calmarrow@xxxxxxxxx]
> Sent: Monday, May 14, 2018 6:10 PM
> To: Doug Ledford <dledford@xxxxxxxxxx>
> Cc: Jason Gunthorpe <jgg@xxxxxxxx>; Parav Pandit <parav@xxxxxxxxxxxx>;
> Scott Branden <scott.branden@xxxxxxxxxxxx>; Ray Jui
> <ray.jui@xxxxxxxxxxxx>; linux-rdma@xxxxxxxxxxxxxxx; Qingmin Liu
> <qingmin.liu@xxxxxxxxxxxx>
> Subject: [PATCH v1 0/2] RDMA network namespace issue fixes
> 
> Hi,
> This patchset contains rdma network namespace issue fixes.
> 
> Steps to reproduce issues as follow:
> 1. Bringup container with option '-net=none'
> 
> docker run --privileged --net=none -v /dev/infiniband:/dev/infiniband \
>            -itd --name=container1 roce
> 
> 2. Add PF or VF to container with pipework
> 
> VF_NAME=enP8p1s0f0
> pipework --direct-phys $VF_NAME container1 192.168.1.10/24
> 
> 3. ib_send_lat test with TCP connect or RDMA-CM connect.
> 
> 1) ModeA: TCP connect
> 
> rdma_cm QPs     : OFF
> Data ex. method : Ethernet
> 
> Server: ib_send_lat -d bnxt_re0 -x 3
> Client: ib_send_lat -d bnxt_re0 -x 3 192.168.1.10
> 
> 2) ModeB: IB connect
> 
> rdma_cm QPs     : OFF
> Data ex. method : rdma_cm
> 
> Server: ib_send_lat -d bnxt_re0 -x 3 -z
> Client: ib_send_lat -d bnxt_re0 -x 3 192.168.1.10 -z
> 
> 3) ModeC: IB connect
> 
> rdma_cm QPs     : ON
> Data ex. method : rdma_cm
> 
> Server: ib_send_lat -d bnxt_re0 -x 3 -R
> Client: ib_send_lat -d bnxt_re0 -x 3 192.168.1.10 -R
> 
> Without patch #1, it will fail to get ip_route_output_key because it still uses
> init_net namespace.
> Without patch #2, it cannot setup ib connection.
> 
> This patchset has been tested on Broadcom SST100 board.
> 
> Qingmin Liu (2):
>   infiniband: core: fix network namespace issue with container -net=none
>   infiniband: Fix cma_id_from_event net dev missing issue
> 
Thanks for the patches however it is not sufficient enough to avoid crashes.
Based on the current GID reference count series [1] major restructure, 3 more series are coming and in Leon's queue.
They will be posted once the current series [1] review is completed and merged to rdma-next.
1. addr_resolve() to make namespace aware (7 patches)
2. ib_cm_event and rdmacm net namespace extension using ib_cm_event gid attribute (4 patches)
3. validation of net ns (2 patches)
This helps to make it work over more configuration than just PF and VF.

[1] https://www.spinics.net/lists/linux-rdma/msg64663.html

>  drivers/infiniband/core/addr.c |  2 +-
>  drivers/infiniband/core/cma.c  | 14 ++++++++++----
>  2 files changed, 11 insertions(+), 5 deletions(-)
> 
> --
> 2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux