On Wed, May 09, 2018 at 10:58:54AM -0600, Parav Pandit wrote: > > So move the function comments from the .h to the .c? > > Yes. > > > Is this practice documented somewhere? I don't see mention of it in > > Documentation/doc-guide/kernel-doc.rst. All the functions in > Kernel-doc.rst allows both. > However lot of other kernel follows C file convention, to my knowledge netdev stack. > > > include/rdma/rdma_cm.h have the function comments in the .h, so moving > > these new ones would break the format of the rdma_cm module as it stands. > > > It ok to break in spirit to follow rest of the kernel style for new function addition. > Wherever I am touching function signatures, I am moving them to c file. We've been trying to clean up the RDMA stuff to consistently use only the .c file. We have a weird mix and match today that doesn't make any sense. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
