Re: [PATCH] IB/srpt: Increase port count

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2018-05-14 at 05:03 -0700, Christoph Hellwig wrote:
> On Thu, May 10, 2018 at 03:32:09PM -0700, Bart Van Assche wrote:
> > Since there are adapters that have four ports, increase the size of
> > the srpt_device.port[] array. This patch avoids that the following
> > warning is hit with quad port Chelsio adapters:
> > 
> >     WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port));
> 
> Should we add a IB_MAX_PORTS define that ULPs can rely on in the core?

How many drivers would benefit from the introduction of such a constant?
A third possible alternative is that I change the port array in the ib_srpt
driver such that it is allocated dynamically. That would allow to eliminate
the WARN_ON() statement mentioned above.

Bart.


��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux