On 5/10/18 8:19 AM, Steve Wise wrote: > > On 5/9/2018 11:08 PM, David Ahern wrote: >> On 5/7/18 9:53 AM, Steve Wise wrote: >>> @@ -152,7 +153,10 @@ int main(int argc, char **argv) >>> pretty_output = true; >>> break; >>> case 'd': >>> - show_details = true; >>> + if (show_details) >>> + show_driver_details = true; >>> + else >>> + show_details = true; >>> break; >>> case 'j': >>> json_output = true; >> The above change should be reflected in the man page. > > I did mention it in the man page: > > -d, --details > Output detailed information. Adding a second -d includes > driver-specific details. > > But I wasn't sure how to show it in the syntax. Maybe this? > > OPTIONS := { -V[ersion] | -d[etails] [-d[etails]] } -j[son] } -p[retty] } I should have read the second patch before commenting. Didn't it have first -d = details, a second -d = driver details? That should be fine. > > >> Also, the set needs to be respun after I merged master where Stephen >> brought in updates to the uapi files. > > Will do. Thanks for reviewing. > > Steve. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html