> -----Original Message----- > From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma- > owner@xxxxxxxxxxxxxxx] On Behalf Of Dennis Dalessandro > Sent: Wednesday, May 09, 2018 7:51 AM > To: Leon Romanovsky <leon@xxxxxxxxxx>; Doug Ledford > <dledford@xxxxxxxxxx>; Jason Gunthorpe <jgg@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leonro@xxxxxxxxxxxx>; RDMA mailing list <linux- > rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens <danielj@xxxxxxxxxxxx>; Parav Pandit > <parav@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 2/2] IB/core: Reuse gid_table_release_one() in > table allocation failure > > On 5/2/2018 6:12 AM, Leon Romanovsky wrote: > > -static void gid_table_release_one(struct ib_device *ib_dev) -{ > > - struct ib_gid_table *table; > > - u8 port; > > - > > - for (port = 0; port < ib_dev->phys_port_cnt; port++) { > > - table = ib_dev->cache.ports[port].gid; > > - release_gid_table(table); > > - ib_dev->cache.ports[port].gid = NULL; > > - } > > + gid_table_release_one(ib_dev); > > + return -ENOMEM; > > } > > So now it would be even easier to get rid of the goto. Just a nit though and this > is OK by me. > Yes. goto can be removed now. Will do sometime later once I am done with some pending patches. Thanks for the review. ��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
