Re: [PATCH for-next 09/14] IB/hfi1: Rework fault injection machinery

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, May 02, 2018 at 06:43:24AM -0700, Dennis Dalessandro wrote:
> diff --git a/drivers/infiniband/hw/hfi1/Makefile b/drivers/infiniband/hw/hfi1/Makefile
> index ce4010b..f451ba9 100644
> +++ b/drivers/infiniband/hw/hfi1/Makefile
> @@ -14,7 +14,15 @@ hfi1-y := affinity.o chip.o device.o driver.o efivar.o \
>  	qp.o qsfp.o rc.o ruc.o sdma.o sysfs.o trace.o \
>  	uc.o ud.o user_exp_rcv.o user_pages.o user_sdma.o verbs.o \
>  	verbs_txreq.o vnic_main.o vnic_sdma.o
> -hfi1-$(CONFIG_DEBUG_FS) += debugfs.o
> +
> +ifdef CONFIG_DEBUG_FS
> +hfi1-y += debugfs.o
> +ifdef CONFIG_FAULT_INJECTION
> +ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
> +hfi1-y += fault.o
> +endif
> +endif
> +endif

This seems goofy. Why does configfs allow something called
CONFIG_FAULT_INJECTION_DEBUG_FS to be turned on without its
dependencies?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux