RE: [PATCH rdma-rc] RDMA/cma: Zero out qp and ah attribute

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > -       ret = ib_query_gid(id_priv->id.device, id_priv->id.port_num,
> > -                          rdma_ah_read_grh(&qp_attr.ah_attr)-
> >sgid_index,
> > -                          &sgid, NULL);
> > -       if (ret)
> > -               goto out;
> > -
> 
> Well, this was serving to ensure that the sgid index is present in the
> table for protocols that use gids.
> 
> Presumably modify_qp will check this too though?

The protocols exchange gids, so there should have been a prior conversion from the gid to get the index...  But if a check is needed, I think it needs to be done within modify_qp to avoid potential races.

- Sean
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux