On Sat, 2018-04-28 at 08:53 -0700, Steve Wise wrote:
> This series adds new resource tracking attributes and APIs for
> rdma providers to add their own implementation specific attributes.
> Included in this series is the core changes, and a cxgb4-specific QP
> implementation.
I'm pretty happy with this version Steve. It allows the kernel to tell
what each type should look like (hex, string, whatever) but doesn't
attempt to tell it how to format anything beyond single elements, which
seems the right balance to me. We don't know things like screen
attributes or anything else that would play into those larger formatting
concerns. But knowing that a given element is best displayed as hex
instead of decimal makes lots of sense. I've applied this to my wip/dl-
for-next, so unless Jason has objections within the next 24 hours or so,
it'll be in the next official for-next.
> Changes since v3:
> - reference the print type enum to be used with the attribute in
> a comment when defining the attribute
> - remove dev/link provider patch until we have a user
> - get rid of provider_fill_res_entry() by adding a noop default
> function.
> - remove nesting attributes in iw_cxgb4 fill funcs
> - remove any formating attempts by iw_cxgb4 fill funcs
>
> Changes since v2:
> - remove cb from provider fill API functions
> - null out function pointers explicitly
> - remove BIN print type
> - provide unspec and hex helpers, and only the ones needed for this
> submission
> - rebased on to rdma-next
>
> Changes since v1:
> - refactor provider attr code to remove X32/X64 attributes.
> - add helper functions for filling out provider attributes
> - make use of helpers in cxgb4/restrack.c
> - add Reviewed-by tag.
>
> Changes since v0/rfc:
> - removed RFC tag
> - add PAD attribute while preserving the ABI
> - remove "provider_" prefix from restrack_root fn ptr names.
> - enable link and dev provider-specific attributes.
> - fixed copyright dates on cxgb4/restack.c.
>
> Steve Wise (4):
> RDMA/nldev: Add explicit pad attribute
> RDMA/nldev: add provider-specific resource tracking
> RDMA/NLDEV: helper functions to add provider attributes
> iw_cxgb4: dump detailed provider-specific QP information
>
> drivers/infiniband/core/nldev.c | 122 ++++++++++++++--
> drivers/infiniband/core/restrack.c | 7 +
> drivers/infiniband/hw/cxgb4/Makefile | 3 +-
> drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 5 +
> drivers/infiniband/hw/cxgb4/provider.c | 8 ++
> drivers/infiniband/hw/cxgb4/restrack.c | 248 +++++++++++++++++++++++++++++++++
> include/rdma/restrack.h | 22 +++
> include/uapi/rdma/rdma_netlink.h | 26 ++++
> 8 files changed, 429 insertions(+), 12 deletions(-)
> create mode 100644 drivers/infiniband/hw/cxgb4/restrack.c
>
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
