Re: [PATCH for-rc 1/2] iw_cxgb4: RDMA write with immediate support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 25, 2018 at 05:36:19PM +0530, Potnuri Bharat Teja wrote:

> +	if (wr->opcode == IB_WR_RDMA_WRITE_WITH_IMM)
> +		wqe->write.immd_data = wr->ex.imm_data;

Are you checking your stuff with sparse? The above should give a
sparse failure..

>  enum {
> -	C4IW_QPF_ONCHIP = (1 << 0)
> +	C4IW_QPF_ONCHIP 	= (1<<0),
> +	C4IW_QPF_WRITE_W_IMM    = (1<<1)

Ugh I really hate this columnar alignment stuff. Please don't change
perfectly good lines just to add white space :(

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux