ib_srpt WARN_ON()

[Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>]

Hey Bart, I see this warning when srpt adds a 4 port cxgb4 rnic:

[ 1247.223340] WARNING: CPU: 2 PID: 7639 at
drivers/infiniband/ulp/srpt/ib_srpt.c:3026 srpt_add_one+0x3fa/0x410 [ib_srpt]

from srpt_add_one():
...
        WARN_ON(sdev->device->phys_port_cnt > ARRAY_SIZE(sdev->port));
...

It looks like the srpt code assumes only two port cards:

struct srpt_device {
        struct ib_device        *device;
        struct ib_pd            *pd;
        u32                     lkey;
        struct ib_srq           *srq;
        struct ib_cm_id         *cm_id;
        int                     srq_size;
        struct mutex            sdev_mutex;
        bool                    use_srq;
        struct srpt_recv_ioctx  **ioctx_ring;
        struct srpt_port        port[2];   <<--------  HERE
        struct ib_event_handler event_handler;
        struct list_head        list;
};

That assumption is certainly invalid since Chelsio has 4 port adapters. 
But this also begs the question if ib_srp and ib_srpt should actually
try and use iWARP devices?  Isn't it an IB-only protocol?

Thanks,


Steve.



��.n��������+%������w��{.n�����{���fk��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f