On Thu, 2018-04-26 at 21:47 +0300, Leon Romanovsky wrote:
> On Thu, Apr 26, 2018 at 05:50:14PM +0200, Roman Penyaev wrote:
> > Hi Doug, Christoph, Sagi, Or and all,
> >
> > I completely forgot to write a cover letter for this series, my bad.
> > This is an attempt to make a device pool out of the common code
> > which is used on nvme (host, target) and iser (host, target) and
> > caches the ib_device and ib_pd. This device pool api would be used
> > for IBTRS (rdma transport library) as well.
> >
> > Guys, could you please take a look?
>
> It is still worth to write proper cover letter so we will see complete
> diffstat and it will help us to see the actual gain.
I agree with Leon. I'd like to see the final diffstat to know if this
is doing what a good core function should do and actually reducing the
lines of code in total by reducing duplication. Also, the function
ib_pool_dev_find_get_or_create() is a mouthful of a function name, I
wouldn't mind something shorter that is less likely to result in odd
line splits in use. And of course, no BUG_ON()s left in the code.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
