On Mon, 2018-04-16 at 19:28 -0500, Frederick Lawler wrote:
> The IB/hfi1 driver uses custom macros to configure the target link speed. Some
> macros were previously replaced, but not fully. This patch series addresses the
> configuration inconsistencies by adding PCI_EXP_LNKCTL2_TLS* macros to PCI,
> and then use them in the following IB/hfi1 patch.
>
> V3:
> * PCI: Add PCI_EXP_LNKCTL2_TLS_* macros
> * Drop patch to use extract_speed() in do_pcie_gen3_transition()
> V2:
> * s/LINK/LNK
>
> Frederick Lawler (2):
> PCI: Add PCI_EXP_LNKCTL2_TLS* macros
> IB/hfi1: Replace custom hfi1 macros with PCIe macros
>
> drivers/infiniband/hw/hfi1/pcie.c | 24 ++++++++----------------
> include/uapi/linux/pci_regs.h | 5 +++++
> 2 files changed, 13 insertions(+), 16 deletions(-)
>
Where do we stand on this series? People talked about what the core
might be able to do, or how the driver might be able to do things a
little differently, but I didn't hear a clear conclusion on whether or
not to take this series as is (it seems to be a sensible cleanup and
possibly worthwhile even if we end up changing the hfi1 driver to do a
firmware updated followed by a device reset to get the same results).
And more importantly as far as I'm concerned, is this sitting on my
plate or on the PCI people's plate?
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
