Re: [PATCH rdma-core] Check for broken strict aliasing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/20/2018 12:17 PM, Jason Gunthorpe wrote:
> On Fri, Apr 20, 2018 at 12:08:10PM -0500, Steve Wise wrote:
>>
>>> From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
>>> Sent: Friday, April 20, 2018 11:57 AM
>>> To: linux-rdma@xxxxxxxxxxxxxxx
>>> Cc: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
>>> Subject: [PATCH rdma-core] Check for broken strict aliasing
>>>
>>> At least the gcc 4.4 that comes with Centos6 does not support this
>>> properly and throws bogus warnings.
>>>
>>> Globally disable strict aliasing for safety on these compilers.
>>>
>>> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
>>>  CMakeLists.txt                 | 10 ++++++++++
>>>  buildlib/RDMA_EnableCStd.cmake | 28 ++++++++++++++++++++++++++++
>>>  2 files changed, 38 insertions(+)
>>>
>>> Here is the patch you wanted Steve.. It works for you?
>> Thanks Jason!  Is there a git repo I can pull this from?  I'll test it out.
> No, just 'git am' it from patchworks:
>
> curl https://patchwork.kernel.org/patch/10353259/mbox/ | git am -
>
> Jason

Hey Jason, I'm still seeing this warning.  Was it supposed to be fixed
by the patch?  I no longer see aliasing warnings, so that part tests good.

[ 26%] Building C object libibverbs/CMakeFiles/ibverbs.dir/enum_strs.c.o
/root/stevo/rdma-core/libibverbs/enum_strs.c: In function
‘ibv_port_state_str’:
/root/stevo/rdma-core/libibverbs/enum_strs.c:63: warning: comparison of
unsigned expression < 0 is always false
/root/stevo/rdma-core/libibverbs/enum_strs.c: In function
‘ibv_event_type_str’:
/root/stevo/rdma-core/libibverbs/enum_strs.c:94: warning: comparison of
unsigned expression < 0 is always false
/root/stevo/rdma-core/libibverbs/enum_strs.c: In function
‘ibv_wc_status_str’:
/root/stevo/rdma-core/libibverbs/enum_strs.c:129: warning: comparison of
unsigned expression < 0 is always false

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux