Re: [PATCH v3 rdma-next 5/5] iw_cxgb4: dump detailed provider-specific QP information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 4/23/2018 8:13 AM, Leon Romanovsky wrote:
> On Fri, Apr 20, 2018 at 04:13:03PM -0600, Jason Gunthorpe wrote:
>> On Fri, Apr 20, 2018 at 04:50:48PM -0500, Steve Wise wrote:
>>
>>> What about a PRINT_FMT type attr?  With an enum value like NEWLINE, INDENT,
>>> etc?
>> The kernel just shouldn't supply that level of string formatting to a
>> user space tool. So weird.
>>
>> The groups might be OK, but they need to make some kind of sense
>> beyond formatting and have some kind of self-description of what the
>> group is.
>>
>> Lets see what Leon thinks
> Sorry for being late, I didn't mean that driver will provide formatting,
> but simply name of the proposed attribute, so rdmatool will print it as
> is, all grouped together.
>
> # rdma -dd res show qp lqpn 1
> ....
> driver_field_name_1 driver_field_value_1 driver_field_name_2 driver_field_value_2 driver_field_name_3 driver_field_value_3
>
> It is important to keep formatting in this simple format so all "awk"
> scripts will have access to values fields very easily.
>

I use awk often.  So I'm with you on this.  But I was trying to make the
output look like other output in the iproute2 commands.  If you want one
(very) long line, I"m ok with that.  But please don't object, then, when
I post the rdma tool output with these long lines.

Steve.


--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux