RE: [PATCH v3 rdma-next 4/5] RDMA/NLDEV: helper functions to add provider attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Fri, Mar 30, 2018 at 11:03:42AM -0700, Steve Wise wrote:
> > These help rdma providers to fill out the provider entries.
> >
> > Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> >  drivers/infiniband/core/nldev.c | 67
> +++++++++++++++++++++++++++++++++++++++++
> >  include/rdma/restrack.h         | 13 ++++++++
> >  2 files changed, 80 insertions(+)
> >
> > diff --git a/drivers/infiniband/core/nldev.c
> b/drivers/infiniband/core/nldev.c
> > index 0610313..a11fd16 100644
> > +++ b/drivers/infiniband/core/nldev.c
> > @@ -128,6 +128,73 @@ static int provider_fill_port_info(struct sk_buff
> *msg,
> >  		device->res.fill_port_info(msg, device, port) : 0;
> >  }
> >
> > +static int put_provider_name_print_type(struct sk_buff *msg, const char
> *name,
> > +					enum rdma_nldev_print_type
> print_type)
> > +{
> > +	if (nla_put_string(msg, RDMA_NLDEV_ATTR_PROVIDER_STRING,
> name))
> > +		return -EMSGSIZE;
> > +	if (print_type != RDMA_NLDEV_PRINT_TYPE_UNSPEC &&
> > +	    nla_put_u8(msg, RDMA_NLDEV_ATTR_PROVIDER_PRINT_TYPE,
> print_type))
> > +		return -EMSGSIZE;
> > +
> > +	return 0;
> > +}
> > +
> > +static int _rdma_nl_put_provider_u32(struct sk_buff *msg, const char
> *name,
> > +				     enum rdma_nldev_print_type print_type,
> > +				     u32 value)
> > +{
> > +	if (put_provider_name_print_type(msg, name, print_type))
> > +		return -EMSGSIZE;
> > +	if (nla_put_u32(msg, RDMA_NLDEV_ATTR_PROVIDER_U32, value))
> > +		return -EMSGSIZE;
> > +
> > +	return 0;
> > +}
> > +
> > +static int _rdma_nl_put_provider_u64(struct sk_buff *msg, const char
> *name,
> > +				     enum rdma_nldev_print_type print_type,
> > +				     u64 value)
> > +{
> > +	if (put_provider_name_print_type(msg, name, print_type))
> > +		return -EMSGSIZE;
> > +	if (nla_put_u64_64bit(msg, RDMA_NLDEV_ATTR_PROVIDER_U64,
> value,
> > +			      RDMA_NLDEV_ATTR_PAD))
> > +		return -EMSGSIZE;
> > +
> > +	return 0;
> > +}
> > +
> > +int rdma_nl_put_provider_u32(struct sk_buff *msg, const char *name,
> u32 value)
> > +{
> > +	return _rdma_nl_put_provider_u32(msg, name,
> > +					 RDMA_NLDEV_PRINT_TYPE_UNSPEC,
> value);
> > +}
> > +EXPORT_SYMBOL(rdma_nl_put_provider_u32);
> 
> I wonder if this should be EXPORT_SYMBOL_GPL ?
> 
> Jason

I have no clue.  The ib_core module is dual bsd/gpl.   Whatever you think...



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux