On Thu, Apr 12, 2018 at 10:33:45PM +0000, Bart Van Assche wrote:
> On Fri, 2018-04-13 at 01:24 +0300, Leon Romanovsky wrote:
> > /* Found an invalid (free) entry; allocate it */
> > - if (data->props & GID_TABLE_ENTRY_DEFAULT) {
> > - if (default_gid)
> > + if (default_gid) {
> > + /* If default GID is requested than, it
> ^^^^^
> then?
>
> Additionally, please use the recommended comment style (start with /* on a line
> by itself).
Sure
>
> > + * should be one of the reserved entry.
> > + * This ensures that only reserved slots
> > + * are used for reserved GID.
> > + */
> > + if (data->props & GID_TABLE_ENTRY_DEFAULT)
> > empty = curr_index;
> > } else {
> > empty = curr_index;
>
> Has it been considered to change the above nested if-statement into the following,
> which is more compact?
>
> if (!default_gid || (data->props & GID_TABLE_ENTRY_DEFAULT))
> empty = curr_index
Sending new version with compacted version of "if".
Thanks
>
> Thanks,
>
> Bart.
>
>
>
Attachment:
signature.asc
Description: PGP signature
