On Sun, Apr 08, 2018 at 11:21:59AM +0300, Mark Bloch wrote: > >> +## Encapsulate protocols (*ibv_flow_action_encap*) > >> + > >> +A user can create flow actions that implement different encapsulation > >> +protocols. > >> + > >> +*IBV_FLOW_ACTION_ENCAP_RAW* provides the ability to provide unspecified > >> +encapsulation protocol, this can be expressed by passing it in *hdr_proto*. > > > > This man page doesn't actually describe what is supposed to happen. > > > > I guess it is something like > > > > Prepend the given hdr_len bytes of hdr_ptr in front of the packet > > before sending it > > > > ? > > Well, this is mostly true, the HW might be doing some modification to the > headers, like writing the correct checksum value/proper length and stuff > like that, but it's all pretty standard stuff when it comes to encapsulation. Well.. that is a big issue and needs careful explanation. How is the user space to know if the driver supports the 'special' transformations ? Seems like a pretty big gap. > > Given that is RAW the right proto mode? Maybe just 'PREPEND' ? > I think RAW is better, as there might be some other vendors that will need to provide > a type, like MPLS/GRE/VXLAN, and then the PREPEND will look out of place as they > all do pre append. If the HW is changing it then RAW is not a good name. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
