Re: [bug report] RDMA/qedr: Fix uABI structure layouts for 32/64 compat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 04, 2018 at 03:11:07PM +0300, Dan Carpenter wrote:
> Hello Jason Gunthorpe,
> 
> The patch 71e80a4781af: "RDMA/qedr: Fix uABI structure layouts for
> 32/64 compat" from Mar 20, 2018, leads to the following static
> checker warning:
> 
> 	drivers/infiniband/hw/qedr/verbs.c:532 qedr_alloc_pd()
> 	warn: check that 'uresp.reserved' doesn't leak information
> 
> drivers/infiniband/hw/qedr/verbs.c
>    526  
>    527          if (udata && context) {
>    528                  struct qedr_alloc_pd_uresp uresp;
>    529  
>    530                  uresp.pd_id = pd_id;
>    531  
>    532                  rc = qedr_ib_copy_to_udata(udata, &uresp, sizeof(uresp));
>                                                            ^^^^^^^^^^^^^^^^^^^^
> Yup.  Info leak.  I thought I reported this but it must have been
> something else because I can't find it in my inbox.

Ah, I missed that one! :( The other structs changed in the patch are
zero'd already.

Patch sent..

Thanks,
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux