RE: [PATCH] libibverb/examples: Protect against memory corruption

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



>-----Original Message-----
>From: linux-rdma-owner@xxxxxxxxxxxxxxx [mailto:linux-rdma-
>owner@xxxxxxxxxxxxxxx] On Behalf Of Yuval Shaia
>Sent: Sunday, April 1, 2018 2:35 AM
>To: dledford@xxxxxxxxxx; jgg@xxxxxxxxxxxx; leonro@xxxxxxxxxxxx; linux-
>rdma@xxxxxxxxxxxxxxx
>Cc: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>Subject: [PATCH] libibverb/examples: Protect against memory corruption
>
>Make sure num_qp is less than MAX_QP so we will not overrun my_dest
>array.
>
>Signed-off-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>
>---
> libibverbs/examples/srq_pingpong.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/libibverbs/examples/srq_pingpong.c
>b/libibverbs/examples/srq_pingpong.c
>index c289b463..f0a3c221 100644
>--- a/libibverbs/examples/srq_pingpong.c
>+++ b/libibverbs/examples/srq_pingpong.c
>@@ -759,6 +759,12 @@ int main(int argc, char *argv[])
> 		return 1;
> 	}
>
>+	if (num_qp > MAX_QP) {

So shouldn't this be >=?

M

>+		fprintf(stderr, "num_qp %d must be less than %d\n",
>num_qp,
>+			MAX_QP);
>+		return 1;
>+	}
>+
> 	num_wc = num_qp + rx_depth;
> 	wc     = alloca(num_wc * sizeof *wc);
>
>--
>2.14.3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>the body of a message to majordomo@xxxxxxxxxxxxxxx
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux