Re: [PATCH rdma-next] iw_cxgb4: print mapped ports correctly

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Mar 29, 2018 at 05:10:13PM +0530, Potnuri Bharat Teja wrote:
> c4iw_ep_common structure holds the mapped addresses, so while printing
> them, use appropriate pointers.
> 
> Fixes: bab572f1d ("iw_cxgb4: Guard against null cm_id in dump_ep/qp")
> Signed-off-by: Potnuri Bharat Teja <bharat@xxxxxxxxxxx>
>  drivers/infiniband/hw/cxgb4/device.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)

Applied to for-next

> diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c
> index 7a9d0de89d6a..5ce3cd1884b5 100644
> +++ b/drivers/infiniband/hw/cxgb4/device.c
> @@ -220,14 +220,14 @@ static void set_ep_sin_addrs(struct c4iw_ep *ep,
>  {
>  	struct iw_cm_id *id = ep->com.cm_id;
>  
> -	*lsin = (struct sockaddr_in *)&ep->com.local_addr;
> -	*rsin = (struct sockaddr_in *)&ep->com.remote_addr;
> +	*m_lsin = (struct sockaddr_in *)&ep->com.local_addr;
> +	*m_rsin = (struct sockaddr_in *)&ep->com.remote_addr;
>  	if (id) {
> -		*m_lsin = (struct sockaddr_in *)&id->m_local_addr;
> -		*m_rsin = (struct sockaddr_in *)&id->m_remote_addr;
> +		*lsin = (struct sockaddr_in *)&id->local_addr;
> +		*rsin = (struct sockaddr_in *)&id->remote_addr;

Although the commit comment in bab572f1d should have explained why
this code switched from from cm_id->m_local_addr to com.local_addr ..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux