> > On Tue, Mar 27, 2018 at 08:38:07AM -0700, Steve Wise wrote: > > Since the rdma_port_space enum is being passed between > > user and kernel for user cm_id setup, we need it in a > > UAPI header. So add it to rdma_user_cm.h. > > > > This also fixes the cm_id restrack changes which pass up the port space > > value via the RDMA_NLDEV_ATTR_RES_PS attribute. > > > > Fixes: 00313983cda6 ("RDMA/nldev: provide detailed CM_ID information") > > Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> > > --- > > include/rdma/rdma_cm.h | 8 +------- > > include/uapi/rdma/rdma_user_cm.h | 7 +++++++ > > 2 files changed, 8 insertions(+), 7 deletions(-) > > I applied this patch and one before after modifying it as discussed in > the other thread.. Please check it.. > > Jason Thanks Jason! This: @@ -82,7 +90,7 @@ struct rdma_ucm_cmd_hdr { struct rdma_ucm_create_id { __aligned_u64 uid; __aligned_u64 response; - __u16 ps; + __u16 ps; /* use enum rdma_port_space */ __u8 qp_type; __u8 reserved[5]; }; Should the comment be "use rdma_ucm_port_space? " I'll rebase my series and test it all tomorrow first thing. Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html