> On Sat, Mar 24, 2018 at 12:55:41PM +0300, Leon Romanovsky wrote: > > > > + if (nla_put_string(msg, RDMA_NLDEV_ATTR_PROVIDER_STRING, > "sqid")) > > > + goto err_cancel_entry; > > > + if (nla_put_u32(msg, RDMA_NLDEV_ATTR_PROVIDER_U32, wq- > >sq.qid)) > > > + goto err_cancel_entry; > > And if you are going to have this as a standard scheme, probably give > it a helper and drop half the lines.. > > rdma_nl_put_provider_u32(msg, "sqid", wq->sq.qid); > > Jason Good idea. I'll do this... -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
