Re: [PATCH rdma-next 05/15] IB/uverbs: Add flow_action create and destroy verbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 26, 2018 at 04:58:30PM -0600, Jason Gunthorpe wrote:
> > +struct ib_uverbs_flow_action_esp_keymat_aes_gcm {
> > +	__aligned_u64	iv;
> 
> Padding here
>  
> > +	__u32		iv_algo; /* Use enum ib_uverbs_flow_action_esp_keymat_aes_gcm_iv_algo */
> > +
> > +	__u32		salt;
> > +	__u32		icv_len;
> > +
> > +	__u32		key_len;
> > +	__u32		aes_key[256 / 32];
> 
> and implicit padding at the end here

Woops, the weird placement of blank lines threw me off, this one is
fine

> > +struct ib_uverbs_flow_action_esp_encap {
> > +	/* This struct represents a list of pointers to flow_xxxx_filter that
> > +	 * encapsulates the payload in ESP tunnel mode.
> > +	 */
> > +	RDMA_UAPI_PTR(void *, val_ptr); /* pointer to a flow_xxxx_filter */
> > +	RDMA_UAPI_PTR(struct ib_uverbs_flow_action_esp_encap *, next_ptr);
> > +	__u16	len;		/* Len of the filter struct val_ptr points to */
> > +	__u16	type;		/* Use flow_spec_type enum */
> > +};
> 
> Also missing trailing implicit padding.

But this one needs a reserved at the end

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux