On 3/26/2018 4:15 PM, Jason Gunthorpe wrote: > On Mon, Mar 26, 2018 at 09:30:41AM -0500, Steve Wise wrote: >> >> On 3/26/2018 9:17 AM, David Ahern wrote: >>> On 2/27/18 9:07 AM, Steve Wise wrote: >>>> diff --git a/rdma/rdma.h b/rdma/rdma.h >>>> index 5809f70..e55205b 100644 >>>> +++ b/rdma/rdma.h >>>> @@ -18,10 +18,12 @@ >>>> #include <libmnl/libmnl.h> >>>> #include <rdma/rdma_netlink.h> >>>> #include <time.h> >>>> +#include <net/if_arp.h> >>>> >>>> #include "list.h" >>>> #include "utils.h" >>>> #include "json_writer.h" >>>> +#include <rdma/rdma_cma.h> >>>> >>> did you forget to add rdma_cma.h? I don't see that file in my repo. >> It is provided by the rdma-core package, upon which rdma tool now >> depends for the rdma_port_space enum. > It is a kernel bug that enum is not in an include/uapi/rdma header > > Fix it there and don't try to use rdma-core headers to get kernel ABI. > > Jason I wish you'd commented on this just a little sooner. I just resent v3 of this series... with rdma_cma.h included. :) How about the restrack/nldev code just translates the port space from enum rdma_port_space to a new ABI enum, say nldev_rdma_port_space, that i add to rdma_netlink.h? I'd hate to open the can of worms of trying to split rdma_cma.h into uabi and no uabi headers. :( Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
