Re: [PATCH rdma-next 05/15] IB/uverbs: Add flow_action create and destroy verbs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21/03/2018 18:31, Jason Gunthorpe wrote:
On Wed, Mar 21, 2018 at 06:17:27PM +0200, Matan Barak wrote:

So only the kernel macro is wrong, please fix it to

  #define RDMA_UAPI_PTR(_type, _name) __aligned_u64 _name


By doing this, you're loosing the type information.  Why not
defining it both in user-space and kernel as union {_type _name;
__aligned_u64 _name ## _data_u64; }

The kernel can't use the pointer, so why define it for it?


The kernel code could use this type directly. For example, if we have a ULP that wants to use esp flow action directly, it'll have to use this as a pointer.

Are there some macros or something that check it in the kernel?

Jason


Matan
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux