On Tue, Mar 20, 2018 at 07:19:28PM +0000, Parav Pandit wrote: > rdma_restrack_clean() call from ib_unregister_device() is not correct. > rdma_restrack_init() is called in ib_alloc_device(). > The correct cleanup routine of alloc_device() is ib_dealloc_device(). > Therefore rdma_restrack_clean() should be done there. > Ib_unregister_device() is not the right place regardless of what is done in this patch. Not really.. It is a serious error for IB objects to still exist once the client remove callbacks have completed, after that point the driver is gone and the objects won't work right. So it is reasonable to place the assertion that all objects are deleted where it is.. If it did more stuff then maybe something would be needed in dealloc_device, but as is is fine, if not strangely named. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
