On Tue, Mar 20, 2018 at 04:40:41PM +0000, Parav Pandit wrote:
> > > int ib_init_ah_attr_from_path(struct ib_device *device, u8 port_num,
> > > struct sa_path_rec *rec,
> > > @@ -647,6 +661,18 @@ static inline u8 sa_path_get_raw_traffic(struct
> > sa_path_rec *rec)
> > > return 0;
> > > }
> > >
> > > +static inline void
> > > +sa_path_set_roce_route_resolved(struct sa_path_rec *rec, bool
> > > +resolved) {
> > > + rec->roce.route_resolved = resolved; }
> > > +
> > > +static inline bool
> > > +sa_path_roce_is_route_resolved(const struct sa_path_rec *rec) {
> > > + return rec->roce.route_resolved;
> > > +}
> >
> > This isn't C++/Java, we don't need accessors like this without a good reason..
> May I know the good reason for existence of simple accessors APIs
> such as rdma_ah_set_sl() and rdma_ah_get_sl() which were added less
> than a year ago, that too without any kdoc given that it is exported
> in include/rdma/ib_verbs.h and reviewed by at least 4 people?
> Someone is supposed to cleanup those APIs too?
No idea, they mostly do not seem to be a good idea either.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
