Re: [PATCH rdma-rc 1/2] RDMA/restrack: Add ability to create non-traceable restrack objects

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 20, 2018 at 09:49:12AM -0600, Jason Gunthorpe wrote:
> On Tue, Mar 20, 2018 at 03:45:36PM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> >
> > The fact that Resource tracking 02d8883f520e ("RDMA/restrack: Add general
> > infrastructure to track RDMA resources") was added immediately after
> > commit 16c1975f1032 ("IB/mlx5: Create profile infrastructure to add and
> > remove stages") caused to miss the fact that PD and CQ should be skipped
> > from resources tracking for the UMR allocations.
>
> Why should they be skipped from tracking?
>
> Are they driver internal or something? Confusing.

UMR is based on driver internal QPs, but to create them mlx5_ib uses general PD and CQ.

So without this patch, we have WARN_ON and memory leaks on shutdown,
without 42cea83f9524 we have panics on shutdown while we have traffic.

Can we apply it and move further?

Thanks

>
> Jason
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux