On Tue, Mar 20, 2018 at 06:49:58AM +0200, Leon Romanovsky wrote:
> On Mon, Mar 19, 2018 at 05:05:07PM -0600, Jason Gunthorpe wrote:
> > On Wed, Mar 14, 2018 at 02:29:54PM +0200, Yishai Hadas wrote:
> > > From: Matan Barak <matanb@xxxxxxxxxxxx>
> > >
> > > The last ioctl series in the kernel changed the uAPI header.
> > > After this change, the headers are split to two files:
> > > 1. ib_user_ioctl_cmds.h
> > > Represents enums for commands. This should be used internally
> > > in order to form ioctl() commands.
> > > 2. rdma_user_ioctl_verbs.h
> > > Generic ioctl command headers
> > >
> > > Names were changed too in order to clearly mark which enums and
> > > structs are used internally and which are used by applications.
> > > In addition, each element is clearly named with its role.
> > >
> > > This synchronize the user-space with the following kernel commit:
> > > ("IB/uverbs: Move to new headers and make naming consistent")
> > >
> > > Signed-off-by: Matan Barak <matanb@xxxxxxxxxxxx>
> > > Reviewed-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> >
> > This is missing your signed-off-by Yishai, and same for the packet
> > pacing series..
> >
> > Leon: Why didn't the DCO checker notice this?
>
> DCO checks that patch has SOB exactly as author's name and email.
> In this patch, author is Matan and not Yishai, so from DCO point of view
> everything is correct.
Ideally, DCO should check like StephenR does, that the committer and
author have a SOB.
> > I have fixed it up and revised the commits, see the github.
>
> More powerful solution will be if Yishai use proper signature, instead
> of ROB. He is supposed to use SOB for his work.
Yes
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
