Re: [PATCH rdma-next] IB/core: Use rdma_is_port_valid()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 19, 2018 at 07:59:59AM +0200, Leon Romanovsky wrote:
> From: Parav Pandit <parav@xxxxxxxxxxxx>
> 
> Use rdma_is_port_valid() which performs port validity check.
> 
> Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx>
> Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx>
> ---
>  drivers/infiniband/core/cache.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband/core/cache.c
> index 31def0f2ac49..5b9416af825b 100644
> --- a/drivers/infiniband/core/cache.c
> +++ b/drivers/infiniband/core/cache.c
> @@ -937,8 +937,7 @@ int ib_get_cached_subnet_prefix(struct ib_device *device,
>  	unsigned long flags;
>  	int p;
>  
> -	if (port_num < rdma_start_port(device) ||
> -	    port_num > rdma_end_port(device))
> +	if (!rdma_is_port_valid(device, port_num))
>  		return -EINVAL;
>  
>  	p = port_num - rdma_start_port(device);
> @@ -1048,7 +1047,7 @@ int ib_get_cached_port_state(struct ib_device   *device,
>  	unsigned long flags;
>  	int ret = 0;
>  
> -	if (port_num < rdma_start_port(device) || port_num > rdma_end_port(device))
> +	if (!rdma_is_port_valid(device, port_num))
>  		return -EINVAL;
>  

Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

>  	read_lock_irqsave(&device->cache.lock, flags);
> -- 
> 2.14.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux