Re: [PATCH 2/2] IB/rxe: remove unnecessary initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2018/3/19 4:22, Yuval Shaia wrote:
On Sat, Mar 17, 2018 at 10:21:31PM -0400, Zhu Yanjun wrote:
The variable rc is assigned beforce it is used. So it is not
necessary to initialize it.

CC: Srinivas Eeda <srinivas.eeda@xxxxxxxxxx>
CC: Junxiao Bi <junxiao.bi@xxxxxxxxxx>
Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx>
---
  drivers/infiniband/sw/rxe/rxe_verbs.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index f4bab2c..316be50 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -56,7 +56,7 @@ static int rxe_query_port(struct ib_device *dev,
  {
  	struct rxe_dev *rxe = to_rdev(dev);
  	struct rxe_port *port;
-	int rc = -EINVAL;
+	int rc;
if (unlikely(port_num != 1)) {
  		pr_warn("invalid port_number %d\n", port_num);
But then we will goto out with uninitialized rc.
Hi, all

Sure. My bad. Please ignore this patch.

Zhu Yanjun

--
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux