On Wed, Mar 14, 2018 at 8:09 PM, Jason Gunthorpe <jgg@xxxxxxxxxxxx> wrote:
> On Wed, Mar 14, 2018 at 03:22:59PM +0200, Erez Shitrit wrote:
>
>> Perhaps just to take that line ("priv->tx_wr.wr.opcode = IB_WR_SEND;")
>> few lines below, after the call for ipoib_flush_paths(dev) will solve
>> the race.
>>
>> (Because after the call for ipoib_flush_paths() we can be sure that no
>> packets from LSO type will be sent)
>
> But we've already enabled CM mode so we can't be sure a CM packet
> wasn't sent using the wrong wr opcode, so we are back to having the
> original race.
What makes packet to be sent via CM is if it has neigh from CM connection.
so, till ipoib_flush_paths() all packets will be sent UD, after that
new connections requests will be sent via CM.
>
> Could CM and !CM use different priv->tx_wr structs? That would solve
> the problem as well.
Yes, it is an option.
>
> Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
