Re: [PATCH rdma-next 2/2] IB/mlx5: Packet packing enhancement for RAW QP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 13, 2018 at 03:14:20PM +0200, Leon Romanovsky wrote:
> +struct mlx5_ib_burst_info {
> +	__u32       max_burst_sz;
> +	__u16       typical_pkt_sz;
> +};
> +
> +struct mlx5_ib_modify_qp {
> +	__u32			   comp_mask;
> +	struct mlx5_ib_burst_info  burst_info;
> +	__u8                       reserved[6];
> +};

This reserved stuff isn't right, padding is needed in the burst_info
struct, and then a u32 at the end here.

Why do we need the mlx5_ib_burst_info struct anyhow? Just increases
the chance someone will get the padding wrong..

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux