Re: [PATCH RFC rdma-next 2/2] iw_cxgb4: dump detailed provider-specific QP information

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 13, 2018 at 10:30:42AM -0700, Steve Wise wrote:
> Provide a cxgb4-specific function to fill in qp state details.
> This allows dumping important c4iw_qp state useful for debugging.
>
> Included in the dump are the t4_sq, t4_rq structs, plus a dump
> of the t4_swsqe and t4swrqe descriptors for the first and last
> pending entries.
>
> Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/infiniband/hw/cxgb4/Makefile   |   3 +-
>  drivers/infiniband/hw/cxgb4/iw_cxgb4.h |   6 +
>  drivers/infiniband/hw/cxgb4/provider.c |   9 +
>  drivers/infiniband/hw/cxgb4/restrack.c | 363 +++++++++++++++++++++++++++++++++
>  4 files changed, 380 insertions(+), 1 deletion(-)
>  create mode 100644 drivers/infiniband/hw/cxgb4/restrack.c
>
> diff --git a/drivers/infiniband/hw/cxgb4/Makefile b/drivers/infiniband/hw/cxgb4/Makefile
> index fa40b68..9edd920 100644
> --- a/drivers/infiniband/hw/cxgb4/Makefile
> +++ b/drivers/infiniband/hw/cxgb4/Makefile
> @@ -3,4 +3,5 @@ ccflags-y += -Idrivers/net/ethernet/chelsio/libcxgb
>
>  obj-$(CONFIG_INFINIBAND_CXGB4) += iw_cxgb4.o
>
> -iw_cxgb4-y :=  device.o cm.o provider.o mem.o cq.o qp.o resource.o ev.o id_table.o
> +iw_cxgb4-y :=  device.o cm.o provider.o mem.o cq.o qp.o resource.o ev.o id_table.o \
> +	       restrack.o
> diff --git a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> index cc92900..bbdc8dd 100644
> --- a/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> +++ b/drivers/infiniband/hw/cxgb4/iw_cxgb4.h
> @@ -55,6 +55,7 @@
>  #include <rdma/iw_cm.h>
>  #include <rdma/rdma_netlink.h>
>  #include <rdma/iw_portmap.h>
> +#include <rdma/restrack.h>
>
>  #include "cxgb4.h"
>  #include "cxgb4_uld.h"
> @@ -1078,4 +1079,9 @@ void __iomem *c4iw_bar2_addrs(struct c4iw_rdev *rdev, unsigned int qid,
>  void c4iw_invalidate_mr(struct c4iw_dev *rhp, u32 rkey);
>  struct c4iw_wr_wait *c4iw_alloc_wr_wait(gfp_t gfp);
>
> +typedef int c4iw_restrack_func(struct sk_buff *msg,
> +			       struct netlink_callback *cb,
> +			       struct rdma_restrack_entry *res);
> +extern c4iw_restrack_func *c4iw_restrack_funcs[RDMA_RESTRACK_MAX];
> +
>  #endif
> diff --git a/drivers/infiniband/hw/cxgb4/provider.c b/drivers/infiniband/hw/cxgb4/provider.c
> index 1b5c6cd..3f79f19 100644
> --- a/drivers/infiniband/hw/cxgb4/provider.c
> +++ b/drivers/infiniband/hw/cxgb4/provider.c
> @@ -531,6 +531,14 @@ static void get_dev_fw_str(struct ib_device *dev, char *str)
>  		 FW_HDR_FW_VER_BUILD_G(c4iw_dev->rdev.lldi.fw_vers));
>  }
>
> +static int fill_res_entry(struct sk_buff *msg, struct netlink_callback *cb,
> +			  struct rdma_restrack_entry *res)
> +{
> +	return (res->type < ARRAY_SIZE(c4iw_restrack_funcs) &&
> +		c4iw_restrack_funcs[res->type]) ?
> +		c4iw_restrack_funcs[res->type](msg, cb, res) : 0;
> +}
> +
>  void c4iw_register_device(struct work_struct *work)
>  {
>  	int ret;
> @@ -624,6 +632,7 @@ void c4iw_register_device(struct work_struct *work)
>  	dev->ibdev.iwcm->add_ref = c4iw_qp_add_ref;
>  	dev->ibdev.iwcm->rem_ref = c4iw_qp_rem_ref;
>  	dev->ibdev.iwcm->get_qp = c4iw_get_qp;
> +	dev->ibdev.res.provider_fill_res_entry = fill_res_entry;
>  	memcpy(dev->ibdev.iwcm->ifname, dev->rdev.lldi.ports[0]->name,
>  	       sizeof(dev->ibdev.iwcm->ifname));
>
> diff --git a/drivers/infiniband/hw/cxgb4/restrack.c b/drivers/infiniband/hw/cxgb4/restrack.c
> new file mode 100644
> index 0000000..c89d241
> --- /dev/null
> +++ b/drivers/infiniband/hw/cxgb4/restrack.c
> @@ -0,0 +1,363 @@
> +/*
> + * Copyright (c) 2009-2018 Chelsio, Inc. All rights reserved.

Ohh, you wrote this code 9 years ago, impressive :)

Thanks

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux