Re: [PATCH 0/2] Use structs to describe the uABI instead of opencoding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 13, 2018 at 04:33:16PM -0600, Jason Gunthorpe wrote:
> From: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
> 
> To make sure the rxe ABI is fully 32 bit compat clean we actually need to
> define it in the uapi header. This series removes all the open coded
> pointer math and uses sensible structs instead.
> 
> I have a very limited ability to test rxe, and would really appreciate it if
> someone else can help look at this.

I copied rdma_user_rxe.h to buildlib/fixup-include and ran ibv_rc_pingpong
and ibv_ud_pingpong with the updated driver.
No issues detected.

However it works fine even with the original file in
buildlib/fixup-include so not sure i did the right steps.

In case it covers your needs then:

Tested-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx>

> 
> Jason Gunthorpe (2):
>   RDMA/rxe: Get rid of confusing udata parameter to rxe_cq_chk_attr
>   RDMA/rxe: Use structs to describe the uABI instead of opencoding
> 
>  drivers/infiniband/sw/rxe/rxe_cq.c    | 15 +++++-----
>  drivers/infiniband/sw/rxe/rxe_loc.h   | 15 ++++++----
>  drivers/infiniband/sw/rxe/rxe_qp.c    | 26 ++++++++++--------
>  drivers/infiniband/sw/rxe/rxe_queue.c | 24 ++++------------
>  drivers/infiniband/sw/rxe/rxe_queue.h |  5 ++--
>  drivers/infiniband/sw/rxe/rxe_srq.c   | 44 ++++++++++-------------------
>  drivers/infiniband/sw/rxe/rxe_verbs.c | 52 ++++++++++++++++++++++++++++++-----
>  include/uapi/rdma/rdma_user_rxe.h     | 22 +++++++++++++++
>  8 files changed, 120 insertions(+), 83 deletions(-)
> 
> -- 
> 2.16.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux