On Tue, Mar 13, 2018 at 04:06:13PM +0200, Leon Romanovsky wrote: > From: Parav Pandit <parav@xxxxxxxxxxxx> > > Return status of ib_init_ah_from_mcmember() is ignored by > cma_ib_mc_handler(). > Honor it and return error event if ah attribute initialization failed. > > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > --- > drivers/infiniband/core/cma.c | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c > index f1c64b4909d9..2d699bf01aad 100644 > --- a/drivers/infiniband/core/cma.c > +++ b/drivers/infiniband/core/cma.c > @@ -3916,10 +3916,14 @@ static int cma_ib_mc_handler(int status, struct ib_sa_multicast *multicast) > rdma_start_port(id_priv->cma_dev->device)]; > > event.event = RDMA_CM_EVENT_MULTICAST_JOIN; > - ib_init_ah_from_mcmember(id_priv->id.device, > - id_priv->id.port_num, &multicast->rec, > - ndev, gid_type, > - &event.param.ud.ah_attr); > + ret = ib_init_ah_from_mcmember(id_priv->id.device, > + id_priv->id.port_num, > + &multicast->rec, > + ndev, gid_type, > + &event.param.ud.ah_attr); > + if (ret) > + event.event = RDMA_CM_EVENT_MULTICAST_ERROR; > + > event.param.ud.qp_num = 0xFFFFFF; > event.param.ud.qkey = be32_to_cpu(multicast->rec.qkey); > if (ndev) > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
