On Tue, Mar 13, 2018 at 04:06:12PM +0200, Leon Romanovsky wrote: > From: Parav Pandit <parav@xxxxxxxxxxxx> > > ib_find_gid() is only used by IPoIB driver. For IB link layer, GID table > entries are not based on netdevice. Netdevice parameter is unused here. > Therefore, it is removed. > > Reviewed-by: Daniel Jurgens <danielj@xxxxxxxxxxxx> > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx> > Signed-off-by: Parav Pandit <parav@xxxxxxxxxxxx> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx> Reviewed-by: Yuval Shaia <yuval.shaia@xxxxxxxxxx> > --- > drivers/infiniband/core/device.c | 3 +-- > drivers/infiniband/ulp/ipoib/ipoib_ib.c | 2 +- > include/rdma/ib_verbs.h | 2 +- > 3 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c > index e8010e73a1cf..c2d968aa8885 100644 > --- a/drivers/infiniband/core/device.c > +++ b/drivers/infiniband/core/device.c > @@ -1048,13 +1048,12 @@ EXPORT_SYMBOL(ib_modify_port); > * a specified GID value occurs. Its searches only for IB link layer. > * @device: The device to query. > * @gid: The GID value to search for. > - * @ndev: The ndev related to the GID to search for. > * @port_num: The port number of the device where the GID value was found. > * @index: The index into the GID table where the GID was found. This > * parameter may be NULL. > */ > int ib_find_gid(struct ib_device *device, union ib_gid *gid, > - struct net_device *ndev, u8 *port_num, u16 *index) > + u8 *port_num, u16 *index) > { > union ib_gid tmp_gid; > int ret, port, i; > diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c > index 10384ea50bed..f47f9ace1f48 100644 > --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c > +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c > @@ -1085,7 +1085,7 @@ static bool ipoib_dev_addr_changed_valid(struct ipoib_dev_priv *priv) > > netif_addr_unlock_bh(priv->dev); > > - err = ib_find_gid(priv->ca, &search_gid, priv->dev, &port, &index); > + err = ib_find_gid(priv->ca, &search_gid, &port, &index); > > netif_addr_lock_bh(priv->dev); > > diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h > index 7df3274818f9..5ff4eeaa19cb 100644 > --- a/include/rdma/ib_verbs.h > +++ b/include/rdma/ib_verbs.h > @@ -2857,7 +2857,7 @@ int ib_modify_port(struct ib_device *device, > struct ib_port_modify *port_modify); > > int ib_find_gid(struct ib_device *device, union ib_gid *gid, > - struct net_device *ndev, u8 *port_num, u16 *index); > + u8 *port_num, u16 *index); > > int ib_find_pkey(struct ib_device *device, > u8 port_num, u16 pkey, u16 *index); > -- > 2.14.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html