Re: [PATCH rdma-next 00/15] Convert drivers to use kzalloc instead of kmalloc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/12/2018 11:22 AM, Jason Gunthorpe wrote:
On Mon, Mar 12, 2018 at 04:16:16PM +0200, Leon Romanovsky wrote:
From: Leon Romanovsky <leonro@xxxxxxxxxxxx>

Hi,

The reason to this patchset is described in "RDMA/mlx4: Clear all
allocated memory by default" accommodated with relevant crash report.

Well, but you never explained what the actual problem is, and I've failed
to guess...

So I can't judge if changing every alloc in every driver is a sane
idea or some kind of overkill..

Ugh, please no to blindly changing every driver. Would you just replace the kmalloc() definition with a call to kzalloc() in the core kernel? Yeah I'm sure you agree that would never fly, so then why is it OK to do here?

That being said I'm not going to fight that hard or go as far as to nak the patches, but in my personal opinion this isn't really needed for every driver.

-Denny

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux