> -----Original Message----- > From: Jason Gunthorpe > Sent: Monday, March 12, 2018 10:57 AM > To: Parav Pandit <parav@xxxxxxxxxxxx> > Cc: Leon Romanovsky <leon@xxxxxxxxxx>; Hal Rosenstock > <hal@xxxxxxxxxxxxxxxxxx>; Doug Ledford <dledford@xxxxxxxxxx>; RDMA > mailing list <linux-rdma@xxxxxxxxxxxxxxx>; Daniel Jurgens > <danielj@xxxxxxxxxxxx>; Mark Bloch <markb@xxxxxxxxxxxx> > Subject: Re: [PATCH rdma-next 04/13] IB/core: Honor port_num while resolving > GID for IB link layer > > On Mon, Mar 12, 2018 at 09:49:26AM -0600, Parav Pandit wrote: > > > This function is supposed to be called only for IB and/or RoCE flows > > and not for iWarp link layers. Are you suggesting that we add check > > in all such functions (if any) to return failure for iWarp ports? > > (as different path) > > This is a core code function, it isn't a good idea to make such assumptions based > on today's code analysis. > Ok. Leon will you do v1 or I should? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html