On 3/12/2018 9:07 AM, Dennis Dalessandro wrote:
On 3/11/2018 7:51 AM, Leon Romanovsky wrote:
From: Leon Romanovsky <leonro@xxxxxxxxxxxx>
All callers to ib_modify_qp_is_ok() provides enum ib_qp_state
makes the checks of out-of-scope redundant. Let's remove them
together with updating function signature to return boolean result.
I'm not so sure this is true. Rdmavt just pulls the current and new
state and passes but doesn't check. I'm fine adding the checks to rdmavt
if all the other drivers do their own but I would think it's best to
leave the checks in the common/core function and remove the duplicated
code checks from all the drivers.
As far as changing the return type, that I'm on board with.
Guess it would have helped to notice patch 2/4 before this one. I think
that alleviates my concern.
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
