On Wed, Mar 07, 2018 at 08:22:13PM -0700, Jason Gunthorpe wrote:
> On Mon, Feb 26, 2018 at 03:02:21PM +0200, Leon Romanovsky wrote:
> > From: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> >
> > This patch explicitly aligns 'mlx4_uverbs_ex_query_device_resp' layout
> > to u64 and use the correct response's length when copying the data to
> > the user area.
> >
> > The uAPI should be u64 aligned, currently on 64 bit systems this is done
> > implicitly as of the next u64 field in the rss_caps structure.
> >
> > Legacy user space 32 bit system application in any case is broken with
> > 64 bit system kernel before this change.
> >
> > A matching change will be done in the user area for future use also on
> > 32 bit systems.
> >
> > In addition, we move the structure to the uAPI file where it's expected
> > to be from day one.
> >
> > Fixes: 09d208b258a2 ("IB/mlx4: Add report for RSS capabilities by vendor channel")
> > Reviewed-by: Mark Bloch <markb@xxxxxxxxxxxx>
> > Signed-off-by: Yishai Hadas <yishaih@xxxxxxxxxxxx>
> > Signed-off-by: Leon Romanovsky <leon@xxxxxxxxxx>
> > drivers/infiniband/hw/mlx4/main.c | 5 +++--
> > drivers/infiniband/hw/mlx4/mlx4_ib.h | 14 --------------
> > include/uapi/rdma/mlx4-abi.h | 16 ++++++++++++++++
> > 3 files changed, 19 insertions(+), 16 deletions(-)
>
> I applied just the move of struct, I need that part to complete the 32 bit
> compat series and would like it to be distinct..
>
> Since the later patch depends on the reserved thing the series will
> need a quick rework as suggested earlier to be applicable right now,
> sorry.
>
> The first draft of the 32 bit compat series I wrote is here:
>
> https://github.com/jgunthorpe/linux/commits/32compat
Yishai and me reviewed it and it looks fine to us, just don't forget the
main.c part of original patch.
Thanks
>
> Jason
Attachment:
signature.asc
Description: PGP signature
