On Fri, 2018-03-02 at 13:14 -0800, Bart Van Assche wrote:
> Add a parameter for configuring the port on which the ib_srpt driver
> listens for incoming RDMA/CM connections, namely
> /sys/kernel/config/target/srpt/discovery_auth/rdma_cm_port. The default
> value for this parameter is 0 which means "do not listen for incoming
> RDMA/CM connections". Add RDMA/CM support to all code that handles
> connection state changes. Modify srpt_init_nodeacl() such that ACLs can
> be configured for IPv4 and IPv6 addresses.
>
> Note: incoming connection requests are only accepted for ports that
> have been enabled. See also the "if (!sport->enabled)" code in the
> connection request handler. See also the following configfs attribute:
> /sys/kernel/config/target/srpt/$port/$port/enable.
>
> Signed-off-by: Bart Van Assche <bart.vanassche@xxxxxxx>
> ---
>
> Changes compared to the version posted on February 27th:
> - Reduced the number of RDMA/CM IDs back from two to one.
>
> Changes compared to the version posted on February 22nd:
> - Added IPv6 support
> - Removed the inet_ntop() function and switched to snprintf("%pIS").
> - Removed two misleading comments.
>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 380 ++++++++++++++++++++++++++++------
> drivers/infiniband/ulp/srpt/ib_srpt.h | 8 +-
> 2 files changed, 325 insertions(+), 63 deletions(-)
Hi Bart,
This has had 5 days on the list where people could comment, and you've
already met my review, so I'm applying this today. Thanks.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
