> From: Leon Romanovsky [mailto:leon@xxxxxxxxxx] > Sent: Monday, March 05, 2018 11:41 AM > To: Kalderon, Michal <Michal.Kalderon@xxxxxxxxxx> > Cc: davem@xxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; dledford@xxxxxxxxxx; > jgg@xxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; Elior, Ariel > <Ariel.Elior@xxxxxxxxxx> > Subject: Re: [PATCH net] qed: Free RoCE ILT Memory on rmmod qedr > > On Mon, Mar 05, 2018 at 11:04:11AM +0200, Michal Kalderon wrote: > > Rdma requires ILT Memory to be allocated for it's QPs. > > Each ILT entry points to a page used by several Rdma QPs. > > To avoid allocating all the memory in advance, the rdma > > implementation dynamically allocates memory as more QPs are > > added, however it does not dynamically free the memory. > > The memory should have been freed on rmmod qedr, but isn't. > > This patch adds the memory freeing on rmmod qedr (currently > > it will be freed with qed is removed). > > > > An outcome of this bug, is that if qedr is unloaded and loaded > > without unloaded qed, there will be no more RoCE traffic. > > > > The reason these are related, is that the logic of detecting the > > first QP ever opened is by asking whether ILT memory for RoCE has > > been allocated. > > > > In addition, this patch modifies freeing of the Task context to > > always use the PROTOCOLID_ROCE and not the protocol passed, > > this is because task context for iWARP and ROCE both use the > > ROCE protocol id, as opposed to the connection context. > > > > Fixes: dbb799c39717e7b7 > > Your fixes line was truncated. > > Thanks Thanks for noticing, sending V2 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
