Re: [PATCH v5 rdma-core 1/3] ccan: Add bitmap support for rdma-core

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2018/3/5 14:23, Leon Romanovsky wrote:
> On Wed, Feb 28, 2018 at 06:05:17PM +0800, Liuyixian (Eason) wrote:
>>
>>
>> On 2018/2/28 2:46, Jason Gunthorpe wrote:
>>> On Mon, Feb 26, 2018 at 04:40:40PM +0800, Yixian Liu wrote:
>>>> This patch adds bitmap.c and bitmap.h to rdma-core/ccan to
>>>> support bitmap operation, as they depends on endian.h,
>>>> therefore, endian.h also is added.
>>>
>>> Don't really want to include endian.h, and this is a non-starter:
>>>
>>>> +add_definitions("-DHAVE_LITTLE_ENDIAN=1")
>>>> +
>>>
>>> And this header gets -Wshadow warnings.
>>>
>>> Use this patch instead please:
>>>
>> Hi Jason,
>>
>> Thanks, will prepare it in v6.
>> What's your opinion on kernel patch set v5 for for-next?
>> If some revisions are needed, I will fix them in v6 too.
> 
> I took this patch to make your life easier.
> 
> https://github.com/linux-rdma/rdma-core/pull/299
> 
> Thanks
> 

Leon, thanks!

>>
>>> >From 90e2ccb1d7294bc695c64dc3f8a36cd47f8021d0 Mon Sep 17 00:00:00 2001
>>> From: Yixian Liu <liuyixian@xxxxxxxxxx>
>>> Date: Mon, 26 Feb 2018 16:40:40 +0800
>>> Subject: [PATCH] ccan: Add bitmap support for rdma-core
>>>
>>> This patch adds bitmap.c and bitmap.h to rdma-core/ccan to
>>> support bitmap operations.
>>>
>>> The code is modified from the ccan version to work with -Wshadow and
>>> to eliminate the need for endianness conversions. Ww
>>>
>>> Signed-off-by: Yixian Liu <liuyixian@xxxxxxxxxx>
>>> Signed-off-by: Jason Gunthorpe <jgg@xxxxxxxxxxxx>
>>> ---
>>>  buildlib/config.h.in |   1 +
>>>  ccan/CMakeLists.txt  |   2 +
>>>  ccan/bitmap.c        | 125 +++++++++++++++++++++++++++
>>>  ccan/bitmap.h        | 239 +++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  4 files changed, 367 insertions(+)
>>>  create mode 100644 ccan/bitmap.c
>>>  create mode 100644 ccan/bitmap.h
>>>
>>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux