-----Jason Gunthorpe <jgg@xxxxxxxx> wrote: ----- >To: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx> >From: Jason Gunthorpe <jgg@xxxxxxxx> >Date: 03/01/2018 06:18PM >Cc: "'Bernard Metzler'" <BMT@xxxxxxxxxxxxxx>, "'Leon Romanovsky'" ><leon@xxxxxxxxxx>, linux-rdma@xxxxxxxxxxxxxxx >Subject: Re: [PATCH v3 00/13] Request for Comments on SoftiWarp > >On Thu, Mar 01, 2018 at 10:28:00AM -0600, Steve Wise wrote: >> > On Thu, Mar 01, 2018 at 09:29:04AM -0600, Steve Wise wrote: >> > >> > > Maybe to add a network interface to a soft-rdma device like >rxe, we >> could >> > create a syntax like this: >> > > >> > > rdma link set rxe_eth0 dev eth0 >> > >> > More like: >> > >> > rdma link add rxe_eth0 type rxe dev eth0 >> > >> > 'type rxe' triggers the kernel to dispatch to the rxe or siw >driver to >> > create the interface. >> >> Type doesn't sound right though. in the current rdma synax, it >would be >> 'dev'. Maybe: >> >> rdma link add rxe_eth0 dev rxe netdev eth0 > >Type is the consistent tag with 'ip link add'. > >Using 'dev' would be very confusing and surprising since in these >tools it always refers to some existing device. > >Jason > Most of the parameters will be device specific (such as controlling CRC enablement of MPA version for iWarp), but at least one will have to be synchronized, or sanity checked: We likely do not want to have two rdma drivers at the same physical device. As far as I have experienced it, there is currently nothing which prevents that from happening. I can currently register siw on top of a Chelsio Ethernet device which has its iw_cxgb4 driver loaded - same would likely be allowed for siw besides of rxe on the same Ethernet device and IP address. So there should be some common part within the rdma netlink code, which sanitizes adding devices - or would we better add that to the rdma core device registration? Or do we want each driver to check if someone else is in the way (I would find that ugly, and it can't prevent races)? Or shall we simply rely on the skills of the caller ;) Thanks, Bernard. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
