RE: [PATCH v3 rdma-next 07/10] mlx4_ib: set user mr attributes in struct ib_mr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Mon, Feb 26, 2018 at 03:22:38PM -0800, Steve Wise wrote:
> > Setting iova, length, and page_size allows this information to be
> > seen via NLDEV netlink queries, which can aid in user rdma debugging.
> >
> > Signed-off-by: Steve Wise <swise@xxxxxxxxxxxxxxxxxxxxx>
> > ---
> >  drivers/infiniband/hw/mlx4/mr.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/infiniband/hw/mlx4/mr.c
> b/drivers/infiniband/hw/mlx4/mr.c
> > index 4975f3e..17f4f15 100644
> > --- a/drivers/infiniband/hw/mlx4/mr.c
> > +++ b/drivers/infiniband/hw/mlx4/mr.c
> > @@ -407,6 +407,9 @@ struct ib_mr *mlx4_ib_reg_user_mr(struct ib_pd *pd,
> u64 start, u64 length,
> >  		goto err_mr;
> >
> >  	mr->ibmr.rkey = mr->ibmr.lkey = mr->mmr.key;
> > +	mr->ibmr.length = length;
> > +	mr->ibmr.iova = virt_addr;
> > +	mr->ibmr.page_size = 1U << shift;
> 
> I wonder how many other drivers will have updates like this.

I can't test the other drivers for lack of hardware.  They can be fixed as
the vendors discover them.  OR, we don't dump any of this for MRs.  And with
the up and coming provider-specific resources, that will probably be dumped
anyway.

Should I just remove dumping of length/iova/page_size?




--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux