On Thu, 2018-02-22 at 14:09 -0800, Bart Van Assche wrote:
> +static struct rdma_cm_id *srpt_create_rdma_id(u16 rdma_cm_port)
> +{
> + struct rdma_cm_id *rdma_cm_id;
> + struct sockaddr_in addr = { };
> + int ret;
> +
> + rdma_cm_id = rdma_create_id(&init_net, srpt_rdma_cm_handler,
^^^^^^^^^
> + NULL, RDMA_PS_TCP, IB_QPT_RC);
> + if (IS_ERR(rdma_cm_id)) {
> + pr_err("RDMA/CM ID creation failed: %ld\n",
> + PTR_ERR(rdma_cm_id));
> + goto out;
> + }
> +
> + /* We will listen on any RDMA device. */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
The above code, and this comment, do not seem to be in agreement.
What happens if we have some RoCE devices on non-init_net namespaces and
we get an incoming connect on their IP? We're supposedly listening on
the wildcard address, but will we see it?
Otherwise, I'm generally happy with this patch now.
--
Doug Ledford <dledford@xxxxxxxxxx>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDDAttachment:
signature.asc
Description: This is a digitally signed message part
