Re: [PATCH rdma-rc] RDMA/uverbs: Fix kernel panic while using XRC_TGT QP type

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 21, 2018 at 08:18:27PM +0200, Leon Romanovsky wrote:

> > > +	} else {
> > > +		/* It is done in _ib_create_qp for other QP types */
> > > +		qp->uobject = &obj->uevent.uobject;
> > >  	}
> >
> > Steve got rid of this line to make sure the uobject was init'd during
> > restrack add, so why is adding it back here OK for XRC?
> 
> Steve got rid of this line to determine kernel vs. user QPs and not
> because of being XRC. XRC QPs are not participating in restrack
> and IB_QPT_XRC_TGT actually needs this qp->object to be initialized.

But can we not set it someplace where it doesn't break the restrack
assumption even though we don't care today?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux