Re: [PATCHv3 1/1] IB/rxe: remove unnecessary skb_clone

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2018-02-14 at 05:36 -0500, Zhu Yanjun wrote:
> In send_atomic_ack function, it is not necessary to make a
> skb_clone. To gain better performance (high throughput and
> low latency), this skb_clone is removed.
> 
> The following tests are made.
> 
>  server                       client
> ---------                    ---------
> > 1.1.1.1|<----rxe-channel--->|1.1.1.2|
> 
> ---------                    ---------
> 
> On server: rping -s -a 1.1.1.1 -v -C 1000 -S 512
> On client: rping -c -a 1.1.1.1 -v -C 1000 -S 512
> 
> The kernel config CONFIG_DEBUG_KMEMLEAK is enabled on both server
> and client.
> 
> This test runs for several hours. There is no memory leak and the whole
> system can work well.
> 
> As the above network, the following tests are made.
> 
> Server: ibv_rc_pingpong -d rxe0 -g 1
> Client: ibv_rc_pingpong -d rxe0 -g 1 1.1.1.1
> 
> The result on Server(10 tests are made).
> Before:
> Throughput is 137.07 Mbit/sec
> Latency is 517.76 usec/iter
> 
> After:
> Throughput is 148.85 Mbit/sec
> Latency is 476.64 usec/iter
> 
> The throughput is enhanced and the latency is reduced.
> 
> CC: Srinivas Eeda <srinivas.eeda@xxxxxxxxxx>
> CC: Junxiao Bi <junxiao.bi@xxxxxxxxxx>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@xxxxxxxxxx>
> 
> ---
> V2-->V3: Fix typo errors.
> V1-->V2: 10 tests are made. From throughput and latency, the performance is better.

Hi Jason,

I see that the state of this patch in patchworks is Changes Requested,
but from what I can see, the changes were requested of v2 and
implemented in v3.  Was the state of this patch in patchworks switched
by accident possibly, or is there something you were waiting on for the
v3 patch?

-- 
Doug Ledford <dledford@xxxxxxxxxx>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Photo]     [Yosemite News]     [Yosemite Photos]     [Linux Kernel]     [Linux SCSI]     [XFree86]

  Powered by Linux