On Wed, Feb 14, 2018 at 04:41:41PM -0700, Jason Gunthorpe wrote: > On Wed, Feb 14, 2018 at 02:38:31PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > > > The function validate_command_mask() returns only two results: success > > or failure, so convert it to return bool instead of 0 and -1. > > > > Reported-by: Noa Osherovich <noaos@xxxxxxxxxxxx> > > Reviewed-by: Matan Barak <matanb@xxxxxxxxxxxx> > > Signed-off-by: Leon Romanovsky <leonro@xxxxxxxxxxxx> > > drivers/infiniband/core/uverbs_main.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > > index b36cb12b3f38..1be9a93f628c 100644 > > +++ b/drivers/infiniband/core/uverbs_main.c > > @@ -635,7 +635,7 @@ struct file *ib_uverbs_alloc_async_event_file(struct ib_uverbs_file *uverbs_file > > return filp; > > } > > > > -static int verify_command_mask(struct ib_device *ib_dev, __u32 command) > > +static bool verify_command_mask(struct ib_device *ib_dev, __u32 command) > > Shouldn't be __u32, just u32 for in-kernel stuff > > Same comment for all patches Yes, it was __u32 from the beginning. > > Jason
Attachment:
signature.asc
Description: PGP signature
